Clippy fixes

This commit is contained in:
Connor Johnstone
2026-03-04 23:13:40 -05:00
parent 8eb6bb950e
commit d59235707d
6 changed files with 236 additions and 157 deletions

View File

@@ -16,15 +16,14 @@ pub struct TopTrack {
pub name: String,
pub mbid: Option<String>,
pub playcount: u64,
pub listeners: u64,
}
// Last.fm returns {"error": N, "message": "..."} on failure
// Last.fm returns {"error": N, "message": "..."} on failure.
// Only used to detect error responses via serde — fields aren't read directly.
#[derive(Deserialize)]
struct ApiError {
#[allow(dead_code)]
error: u32,
message: String,
}
// Deserialization structs for the Last.fm API responses
@@ -62,7 +61,6 @@ struct TrackEntry {
name: String,
mbid: Option<String>,
playcount: String,
listeners: String,
}
impl LastfmClient {
@@ -87,14 +85,9 @@ impl LastfmClient {
extra_params: &str,
) -> Result<Option<String>, Box<dyn std::error::Error>> {
if let Some(name) = artist_name {
let name = name.replace('\u{2010}', "-")
.replace('\u{2011}', "-")
.replace('\u{2012}', "-")
.replace('\u{2013}', "-")
.replace('\u{2014}', "-")
.replace('\u{2015}', "-")
.replace('\u{2018}', "'")
.replace('\u{2019}', "'");
let name = name
.replace(['\u{2010}', '\u{2011}', '\u{2012}', '\u{2013}', '\u{2014}', '\u{2015}'], "-")
.replace(['\u{2018}', '\u{2019}'], "'");
let encoded = urlencoding::encode(&name);
let url = format!(
"{}?method={}&artist={}&api_key={}{}&format=json",
@@ -163,7 +156,6 @@ impl LastfmClient {
name: t.name,
mbid: t.mbid.filter(|s| !s.is_empty()),
playcount: t.playcount.parse().unwrap_or(0),
listeners: t.listeners.parse().unwrap_or(0),
})
.collect())
}